19.0 Estate tutorial (VIKRI) #1078

vikri-odoo · 2025-12-16T12:42:40Z

Here I have created new add-on for on-boarding tutorial project

what I have done?

Chapter 1: create new add-on for real estate project
Chapter 2: Make your application available in apps
Chapter 3: Created first model for real estate properties
Chapter 4: Added the access rights and basic demo data for properties
Chapter 5: Added Views to see something in action
Chapter 6: Understand how list and form works and create views for properties
Chapter 7: Create one2Many, many2many and many2one relations for properties with Types, tags and offers
Chapter 8: Create methods for onChange and compute to auto set fields
Chapter 9: Added actions for buttons to directly update the model values

robodoo · 2025-12-16T12:42:43Z

barracudapps

Some comments here and there. Can you also please review your PR title and description following our guidelines (https://www.odoo.com/documentation/19.0/contributing/development/git_guidelines.html)?
A clear commit message is really important to describe what you did and why you did it.

real_estate/__init__.py

real_estate/__manifest__.py

real_estate/models/estate.py

real_estate/views/estate_menu.xml

website_airproof/data/presets.xml

Completed till chapter 7 many to one

Added new tags model to understand many2many

barracudapps · 2025-12-18T08:08:50Z

real_estate/models/estate_property.py

    postcode = fields.Char(string="Postcode")
-    date_availability = fields.Datetime(string="Date Availability", default=_set_default_start_date(), copy=False)
+    date_availability = fields.Datetime(
+        string="Date Availability", default=_set_default_start_date(), copy=False


Add a trailing coma here so if someone has to add a new parameter on a new line, that person won't have to change your line (and change the git history)

barracudapps · 2025-12-18T08:09:33Z

real_estate/data/res_estate_data.xml

            <field name="description">Description 3</field>
            <field name="postcode">1040</field>
-            <field name="date_availability" eval="DateTime.now()" />
+            <field name="date_availability" eval="DateTime.now()"/>


date_availability is already pre-defined in your model with your default value

barracudapps · 2025-12-18T08:11:49Z

real_estate/models/estate_property.py

+    state = fields.Selection(
+        string="State",
+        selection=[
+            ("new", "New"),


Use double quotes (") only for non-technical strings.
Please check all your files

barracudapps · 2025-12-18T08:12:35Z

real_estate/security/ir.model.access.csv

 access_estate_property,access.estate.property,model_estate_property,base.group_user,1,1,1,1
-access_estate_property_type,access.estate.property.type,model_estate_property_type,base.group_user,1,1,1,1
+access_estate_property_type,access.estate.property.type,model_estate_property_type,base.group_user,1,1,1,1
+access_estate_property_tags,access.estate.property.tags,model_estate_property_tags,base.group_user,1,1,1,1


Don't forget Unix conventions on text files' structure based on a line definition (cf. https://peps.python.org/pep-0008/ and https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206)

Check other files too

barracudapps · 2025-12-18T08:14:26Z

real_estate/views/estate_menu.xml

+    <menuitem
            id="estate_menu_action"
            action="test_model_action"
            parent="estate_menu_root"
            sequence="1"
-        />


You can keep this on a single line. It's not always easy to know when to write multiple lines but the basic rule is that you try to optimize readability AND number of lines

barracudapps · 2025-12-18T08:15:48Z

real_estate/views/estate_property_templates.xml

 <?xml version="1.0"?>
 <odoo>
-<!--    Root menuitem action which will help us to see the default action window-->
+    <!--    Root menuitem action which will help us to see the default action window-->


This comment is useless as the majority of the developers will easily know what your code is doing

Check the style guide and resolve the issues

1.create new model and view for offers 2.complete chapter 7

1. Sold and cancel button and actions added 2. Accept and reject button added with actions for offers

…n estate_property.py

expected and offer price must be strictly positive Selling price must be positive Tag name should be unique

1.use status bar widget to show the state of the property 2. add default sorting order for the models 3. add colors for tag model 4. add invisible in the needed places as mentioned in the task 5. make the offer and tag editable in list view

barracudapps

Thanks for the module !
Still some small suggestions but LGTM 👍

You can mark as ready (kind of message you'll get in R&D but cannot be applied here)

barracudapps · 2025-12-22T13:21:14Z

real_estate/models/estate_property.py

+    def action_set_sold(self):
+        for record in self:
+            if record.state == 'cancelled':
+                raise UserError("This property cannot be sold.")


Mark your strings as translatable using self.env._ method

barracudapps · 2025-12-22T13:22:21Z

real_estate/models/estate_property_tags.py

+    _name_uniq = models.Constraint(
+        'unique (name)',
+        "This tag is already available",
+    )


Probably fits a single line

barracudapps · 2025-12-22T13:22:46Z

real_estate/models/estate_property_type.py

+
+
+class EstatePropertyType(models.Model):
+    _name = "estate.property.type"


These are tech strings 😉

barracudapps · 2025-12-22T13:23:48Z

real_estate/views/estate_property_templates.xml

+        <field name="name">estate.property.list</field>
+        <field name="model">estate.property</field>
+        <field name="arch" type="xml">
+            <list string="Estate" decoration-success="state=='offered' or state=='accepted'" decoration-bf="state=='accepted'" decoration-muted="state=='sold'">


Try using in to check multiple possible values (instead of or)

barracudapps · 2025-12-22T13:26:08Z

real_estate/views/estate_property_templates.xml

+                <field name="postcode"/>
+                <filter name="available" string="Available" domain="['|', ('state', '=', 'new'), ('state', '=', 'offer_received')]"/>
+                <filter name="inactive" string="Archived" domain="[('active', '=', False)]"/>
+                <field name="living_area" string="Living Area (sqm)" filter_domain="[('living_area', '>=', self)]"/>


Would prefer this for stability

Suggested change

<field name="living_area" string="Living Area (sqm)" filter_domain="[('living_area', '>=', self)]"/>

<field name="living_area" string="Living Area (sqm)" filter_domain="[('living_area', '>=', self)]"/>

[ADD] new addon for real estate onboarding project

36e0588

barracudapps requested changes Dec 16, 2025

View reviewed changes

[ADD] add the new model for property types

528b3cf

Completed till chapter 7 many to one

vikri-odoo changed the title ~~[ADD] new addon for real estate onboarding project~~ 19.0 Estate tutorial (VIKRI) Dec 17, 2025

[LINT] format the code using ruff

abc57b5

Added new tags model to understand many2many

barracudapps requested changes Dec 18, 2025

View reviewed changes

vikri-odoo added 9 commits December 18, 2025 10:00

[REF] address the PR comments and resole it

247d7ca

Check the style guide and resolve the issues

[REF] update the default availability method to lamda

66c0381

[ADD] created new model for estate offers

d00c06f

1.create new model and view for offers 2.complete chapter 7

[ADD] chapter 9: action added for buttons

484f590

1. Sold and cancel button and actions added 2. Accept and reject button added with actions for offers

[LINT] format the code to fix the ci\style issue

477c360

[FIX] typo fix the string parameter to lower case for property_type i…

b0bf8ef

…n estate_property.py

[ADD] constrains added for selling and expected prices

ad8f8af

expected and offer price must be strictly positive Selling price must be positive Tag name should be unique

[ADD] complete the chapter 11

caaffd2

1.use status bar widget to show the state of the property 2. add default sorting order for the models 3. add colors for tag model 4. add invisible in the needed places as mentioned in the task 5. make the offer and tag editable in list view

[REM] unused print statement removed

bc20c35

barracudapps approved these changes Dec 22, 2025

View reviewed changes



		class EstatePropertyType(models.Model):
		_name = "estate.property.type"

	<field name="living_area" string="Living Area (sqm)" filter_domain="[('living_area', '>=', self)]"/>
	<field name="living_area" string="Living Area (sqm)" filter_domain="[('living_area', '>=', self)]"/>

19.0 Estate tutorial (VIKRI) #1078

Are you sure you want to change the base?

19.0 Estate tutorial (VIKRI) #1078

Uh oh!

Conversation

vikri-odoo commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robodoo commented Dec 16, 2025

Uh oh!

barracudapps left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

barracudapps left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vikri-odoo commented Dec 16, 2025 •

edited

Loading